Skip to content

fix: correctness check for find_zero#201

Merged
ganler merged 1 commit intoevalplus:masterfrom
Co1lin:master
May 14, 2024
Merged

fix: correctness check for find_zero#201
ganler merged 1 commit intoevalplus:masterfrom
Co1lin:master

Conversation

@Co1lin
Copy link
Contributor

@Co1lin Co1lin commented May 14, 2024

  • Should use abs to make sure the result is near zero.
  • Should use continue to skip the following regular checks for other problems. Otherwise, even a correct one passes this assertion, it may fail when applying other checks which are incompatible to this problem.

@ganler ganler merged commit 899b2b3 into evalplus:master May 14, 2024
@adamstorek
Copy link

Using continue in fact breaks the checker again, since details[i] is not set to True, so the logic in untrusted_check marks even correct solutions (including the canonical solution) as FAIL.

@Co1lin
Copy link
Contributor Author

Co1lin commented Oct 26, 2024

@adamstorek Thanks for your comments! Maybe add details[i] = True between assert and continue?

@ganler ganler mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants