Split this project up into the separate branches. #7

Activity

1. boonya

   added

   enhancement

   question

   on Jan 11, 2016
2. boonya

   self-assigned this

   on Jan 11, 2016
3. rmk135 commented on Jan 11, 2016

   

   rmk135

   on Jan 11, 2016

   Member

   More actions

   It's interesting idea... Let's start with discussion!

   One thing, that I'm 100% sure is that the name of current repository should be something like PY.VIMRC, but not VIMRC (in case we will live it with the current content).

   The number one question here is what do you propose to include in "just pure vim with basic configurations"?
4. boonya commented on Jan 11, 2016

   

   boonya

   on Jan 11, 2016

   ContributorAuthor

   More actions

   "Pure vim" - it is something like this one https://github.com/boonya/vimrc/tree/without-python
   But I'd like to add NerdTree a bit later and couple of other useful plugins.
5. boonya commented on Jan 11, 2016

   

   boonya

   on Jan 11, 2016

   ContributorAuthor

   More actions

   Here https://github.com/boonya/vimrc/blob/without-python/vimrc#L28 you can see only tree plugins:

   • VundleVim/Vundle.vim
   • flazz/vim-colorschemes
   • bling/vim-airline

   And nothing about specific customisation like virtualenv, jinja, python-pep8-indent and so on...
6. rmk135 commented on Jan 11, 2016

   

   rmk135

   on Jan 11, 2016

   Member

   More actions

   I think that it makes sense, but how do you think about having 2 separate repos for that - VIMRC & PYVIMRC?

   Or how do you see usage of 2 separate branches for this?

   I'm asking because my initial idea was to create environment for the python developers only and I'm not very familial with other guy tasks and their needs.
7. boonya commented on Jan 11, 2016

   

   boonya

   on Jan 11, 2016

   ContributorAuthor

   More actions

   About two separate branches... We can use command like git clone -b python --single-branch https://github.com/ets-labs/vimrc.git ~/.vim for checkout on only one specific branch. It should work with Git 1.7.10 and later. For older versions of Git git clone -b python https://github.com/ets-labs/vimrc.git ~/.vim.

   And I'm not really sure regarding to separate repos. It is still VIM but with different plugins.
8. rmk135 commented on Jan 11, 2016

   

   rmk135

   on Jan 11, 2016

   Member

   More actions

   Ok, gotcha! So, here is my proposal:

   • Move all python specific plugins / options to separate file (something like vimrc_mod_python).
   • Rename setup script from init.sh to setup.sh.
   • Put optional param for setup script that will define required config's content - setup.sh python or setup.sh basic / add special step that will ask user about required config's content.
   • Put source vimrc_mod_python (it works like include directive) into vimrc during the installation process based on user's needs.

   PS

   Just a few thoughts about previous ideas:

   • I do agree that the idea of having different repos for python and basic configuration is no the best one.
   • I'm not sure that the idea of having two separate branches can work well for all cases. For example, if we make some common change that is suitable for both functionalities, we should always keep in mind to cherry-pick in both branches. May be I miss something here, if the problem is not relevant, please, let me know.
   • I do not like different ways of cloning repo based on client git's version. If there is a solution that works for everybody - we should use it.
9. rmk135

   removed

   question

   on Jan 14, 2016