Skip to content

Increase memory limit for POST processing to 32kb #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etr merged 1 commit into from
Apr 19, 2016
Merged

Increase memory limit for POST processing to 32kb #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/webserver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,9 +673,10 @@ int webserver::bodyfull_requests_answer_first_step(
)
)
{
const size_t post_memory_limit (32*1024); // Same as #MHD_POOL_SIZE_DEFAULT
mr->pp = MHD_create_post_processor (
connection,
1024,
post_memory_limit,
Copy link
Owner

@etr etr Apr 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use the constant #MHD_POOL_SIZE_DEFAULT directly so that in case it changes in libmicrohttpd also libhttpserver will immediately benefit from the change?

Copy link
Contributor Author

@wlandry wlandry Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, MHD_POOL_SIZE_DEFAULT is only defined in src/microhttpd/daemon.c. So it is not visible to library users.

Copy link
Owner

@etr etr Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - not much we can do then.

&post_iterator,
mr
);
Expand Down