Move http_response class members to private. #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They never should have been protected in the first place, as they are accessible through class methods.
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 35 35
Lines 3140 3140
=======================================
Hits 2989 2989
Misses 151 151
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
As by discussion in this PR: #180 . The http_response object contains protected members for no apparent reason. This, besides making the internals of the class visible from the outside, impedes improvement to the code.
Description of the Change
Move the members to the private section.
There wasn't really a good reason for them to be protected in the first place. It was just a residual from before the Jan 2019 cleanup to the http_response chain of dependencies.
Possible Drawbacks
If external code has taken a dependency on these fields, this change would result in a failure for such code.
Verification Process
unit/integration testing. The change will also run through Travis before being pushed.
Release Notes
All protected class members variables in http_response have been changed to be private.