Major findings resolved: - peer_address.cpp: add static_cast<unsigned> before IPv6 byte shifts to eliminate signed-int promotion UB and %x format-specifier mismatch (findings #1/#25, CWE-704) - webserver_impl.hpp: rewrite any_hooks_ comment — remove "relaxed", expand acquire-pairing rationale with the correct hot-path pattern (finding #2, race-condition risk in future TASK-046+ consumers) - hook_handle.hpp: add @warning lifetime block documenting the raw-pointer use-after-free risk and safe usage patterns (finding #3, CWE-416) - webserver_impl.hpp: add phase_hook_count(hook_phase) accessor; test phase_size helper now delegates to it, decoupling test from field names (finding #4) Minor findings resolved: - hook_phase.hpp: remove verbose std::string_view{} wrappers from to_string - hook_action.hpp: add assert(response_.has_value()) precondition guard in take_response() (finding #26, CWE-476) - hook_context.hpp: add @security doc blocks on request_received_ctx and before_handler_ctx mutable pointer fields (finding #27) - hook_context.hpp: update to_string placement comment (finding #28) - hook_handle.cpp: use erase_if_found return value in each switch arm to skip gate reset on no-op erase; add explanatory comment (findings #9/#10/#19) - hook_handle.cpp: add detach() inline comment distinguishing detached-disarmed from default-disarmed state (finding #8) - hook_handle.cpp: add TODO comment on switch repetition trade-off (#7/#17) - webserver.cpp: add comment on any_hooks_ store-under-lock redundancy (#24) - test: add add_hook_throws_on_phase_mismatch + add_hook_throws_on_empty_callable runtime tests (finding #11) - test: strengthen double_remove_is_noop with observable assertions (#12/#32) - test: capture detached handle in detach_disarms_destructor (#13) - test: add move_assign_removes_target_registration runtime test (#14) - test: verify take_response() returns correct status in hook_action test (#31) - test: add second remove() to default_constructed_handle_is_inert (#33) - test: add accept_decision_hook_callable pinned-phase SFINAE static_assert (#34) - test: add design-intent comment explaining compile-time vs runtime split (#29) - spec: mark all 34 items resolved/deferred in findings file Deferred: hooks.md doc updates (#5/#6), detach refactor (#15/#18), lambda inlining (#16), port 0 cleanup (#30), per-phase mutex (#23). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Performance Improvement: Conditionals #32

Description

Activity

etr commented on Aug 26, 2012

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions