hargobind-atwal #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisanSuarez
reviewed
Mar 8, 2019
Data_Structures_Answers.md
Outdated
|
|
||
| 7. What is the runtime complexity of your optimized code in `names.py`? | ||
|
|
||
| (n log n)^2 |
There was a problem hiding this comment.
just get rid of the **2 and you've got it :)
LuisanSuarez
reviewed
Mar 8, 2019
| duplicates = [] | ||
| for name_1 in names_1: | ||
| if bst.contains(name_1): | ||
| if binary_search(names_2, name_1): |
There was a problem hiding this comment.
nice going. personally, I like this better than risking having an unbalanced BST.
LuisanSuarez
reviewed
Mar 8, 2019
| self.left = None | ||
| self.right = None | ||
|
|
||
| def depth_first_for_each(self, cb): |
LuisanSuarez
reviewed
Mar 8, 2019
| def breadth_first_for_each(self, cb): | ||
| pass | ||
| queue = [] | ||
| queue.insert(0, self) |
There was a problem hiding this comment.
aaand nice :) only real change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.