Repository navigation
Conversation
|
Everything looks good for day 1, great job figuring out the problems and new syntax. |
JGolden25
reviewed
Feb 13, 2019
| # YOUR CODE HERE | ||
| class Geocache(Waypoint): | ||
| def __init__(self, name, difficulty, size, lat, lon): | ||
| Waypoint.__init__(self, name, lat, lon) |
There was a problem hiding this comment.
super could be applied here to make your code DRYer in the long run
super().init(name, lat, lon)
over all nice job finishing classes, this part will help you w/the rest of the week
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JGolden25 I think I did this right