fix: correct Scope typings (#20198)

jaymarvelz · web-flow · commit 927272d1f0d5 · 2025-10-30T17:16:39.000+01:00
diff --git a/lib/types/index.d.ts b/lib/types/index.d.ts
@@ -148,6 +148,10 @@ export namespace Scope {
 		references: Reference[];
 		through: Reference[];
 		functionExpressionScope: boolean;
+		implicit?: {
+			variables: Variable[];
+			set: Map<string, Variable>;
+		};
 	}
 
 	interface Variable {
@@ -188,7 +192,14 @@ export namespace Scope {
 				node: ESTree.FunctionDeclaration | ESTree.FunctionExpression;
 				parent: null;
 		  }
-		| { type: "ImplicitGlobalVariable"; node: ESTree.Program; parent: null }
+		| {
+				type: "ImplicitGlobalVariable";
+				node:
+					| ESTree.AssignmentExpression
+					| ESTree.ForInStatement
+					| ESTree.ForOfStatement;
+				parent: null;
+		  }
 		| {
 				type: "ImportBinding";
 				node:
diff --git a/tests/lib/types/types.test.ts b/tests/lib/types/types.test.ts
@@ -499,6 +499,10 @@ const scopeManager: Scope.ScopeManager = {
 
 const scope = scopeManager.scopes[0];
 
+scope.implicit;
+scope.implicit?.variables;
+scope.implicit?.set;
+
 const variable = scope.variables[0];
 
 variable.name = "foo";
@@ -524,6 +528,37 @@ reference.isWrite();
 reference.isWriteOnly();
 reference.isReadWrite();
 
+let catchDef!: Extract<Scope.DefinitionType, { type: "CatchClause" }>;
+catchDef.node; // $ExpectType CatchClause
+catchDef.parent; // $ExpectType null
+
+let classNameDef!: Extract<Scope.DefinitionType, { type: "ClassName" }>;
+classNameDef.node; // $ExpectType ClassDeclaration | ClassExpression
+classNameDef.parent; // $ExpectType null
+
+let functionNameDef!: Extract<Scope.DefinitionType, { type: "FunctionName" }>;
+functionNameDef.node; // $ExpectType FunctionDeclaration | FunctionExpression
+functionNameDef.parent; // $ExpectType null
+
+let implicitGlobalVarDef!: Extract<
+	Scope.DefinitionType,
+	{ type: "ImplicitGlobalVariable" }
+>;
+implicitGlobalVarDef.node; // $ExpectType AssignmentExpression | ForInStatement | ForOfStatement
+implicitGlobalVarDef.parent; // $ExpectType null
+
+let importBindingDef!: Extract<Scope.DefinitionType, { type: "ImportBinding" }>;
+importBindingDef.node; // $ExpectType ImportSpecifier | ImportDefaultSpecifier | ImportNamespaceSpecifier
+importBindingDef.parent; // $ExpectType ImportDeclaration
+
+let parameterDef!: Extract<Scope.DefinitionType, { type: "Parameter" }>;
+parameterDef.node; // $ExpectType FunctionDeclaration | FunctionExpression | ArrowFunctionExpression
+parameterDef.parent; // $ExpectType null
+
+let variableDef!: Extract<Scope.DefinitionType, { type: "Variable" }>;
+variableDef.node; // $ExpectType VariableDeclarator
+variableDef.parent; // $ExpectType VariableDeclaration
+
 // #endregion
 
 // #region Rule
