Skip to content

Fixed a typo in the Excel function call #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ericremoreynolds merged 2 commits into from
Jul 21, 2015
Merged

Fixed a typo in the Excel function call #53

ericremoreynolds merged 2 commits into from
Jul 21, 2015

Conversation

@Tusky
Copy link
Contributor

@Tusky Tusky commented Jul 19, 2015

No description provided.

@ericremoreynolds
Copy link
Owner

ericremoreynolds commented Jul 20, 2015

Hello,

Actually this isn't a typo. The usage of the , or ; character to separate function arguments in Excel depends on your PC's region and language settings. In US English Excel , is used. Could you update your PR to make a note of this rather than changing the formula?

Thanks for the PR, regards,

Eric.

@Tusky
Copy link
Contributor Author

Tusky commented Jul 21, 2015

I didn't know excel's changes separation syntax depending on your system's currency settings.
That sounds silly even for them :) Anyway updated the text to account for both of the versions.

ericremoreynolds added a commit that referenced this pull request Jul 21, 2015
@ericremoreynolds
Merge pull request #53 from Tusky/patch-1
07acfb9 
Added comment regarding Excel locales that use `;` as the function argument separator instead of `,`.
@ericremoreynolds ericremoreynolds merged commit 07acfb9 into ericremoreynolds:master Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tusky @ericremoreynolds