fix: Add explicit imports for types#28
Merged
Merged
Conversation
Don't rely on Rust prelude, use explicit imports.
Hywan
force-pushed
the
fix-macro-imports
branch
from
749dcb2 to
31aa817
Compare
waywardmonkeys
approved these changes
Nov 6, 2023
Contributor
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
I'll merge this, but would it make sense to add an external test case that picks up whatever was failing here to avoid it happening again? (In a subsequent PR)
Contributor
Author
|
I can try yeah. |
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't rely on Rust prelude, use explicit imports.