Skip to content

fix: Add visibility on function and constructor callbacks #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waywardmonkeys merged 1 commit into from
Nov 6, 2023
Merged

fix: Add visibility on function and constructor callbacks #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions javascriptcore-macros/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@ use quote::quote;
pub fn function_callback(_attributes: TokenStream, item: TokenStream) -> TokenStream {
let function = syn::parse::<syn::ItemFn>(item)
.expect("#[function_callback] must apply on a valid function");
let function_visibility = &function.vis;
let function_name = &function.sig.ident;

quote! {
unsafe extern "C" fn #function_name(
#function_visibility unsafe extern "C" fn #function_name(
raw_ctx: javascriptcore::sys::JSContextRef,
function: javascriptcore::sys::JSObjectRef,
this_object: javascriptcore::sys::JSObjectRef,
Expand Down Expand Up @@ -126,10 +127,11 @@ pub fn function_callback(_attributes: TokenStream, item: TokenStream) -> TokenSt
pub fn constructor_callback(_attributes: TokenStream, item: TokenStream) -> TokenStream {
let constructor = syn::parse::<syn::ItemFn>(item)
.expect("#[constructor_callback] must apply on a valid function");
let constructor_visibility = &constructor.vis;
let constructor_name = &constructor.sig.ident;

quote! {
unsafe extern "C" fn #constructor_name(
#constructor_visibility unsafe extern "C" fn #constructor_name(
raw_ctx: javascriptcore::sys::JSContextRef,
constructor: javascriptcore::sys::JSObjectRef,
argument_count: usize,
Expand Down