feat: Implement JSObject::set_property and ::set_property_at_index#15
Merged
Merged
Conversation
This patch removes the `&JSContext` argument from `JSObject::call_as_function`. All the other methods adopt this style, and I believe it makes total sense.
This patch implements `JSObject::set_property`. Behind the scene, it uses `sys::JSOBjectSetProperty`. I'm not familiar with the `attributes` argument (`sys::JSPropertyAttributes`). I've decided to set it to a default value of 0 for now. Creating a new `JSObject::set_property_with_attributes` method later could be a solution.
This patch implements `JSObject::set_property_at_index`. Behind the scene, it uses `sys::JSOBjectSetPropertyAtIndex`.
Contributor
Author
|
Thanks for the fast merge. |
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These patches implement
JSObject::set_propertyand::set_property_at_indexby usingsys::JSObjectSetPropertyandsys::JSObjectSetPropertyAtIndex.It's based on #14. #14 should ideally be merged before.