Use const fn where clippy says it is possible.

waywardmonkeys · waywardmonkeys · commit 5ddad84d4532 · 2024-01-04T00:15:35.000-05:00
diff --git a/src/context.rs b/src/context.rs
@@ -15,7 +15,7 @@ impl JSContext {
     /// # Safety
     ///
     /// Ensure `raw` is valid.
-    pub unsafe fn from_raw(raw: sys::JSGlobalContextRef) -> Self {
+    pub const unsafe fn from_raw(raw: sys::JSGlobalContextRef) -> Self {
         Self { raw }
     }
 
diff --git a/src/exception.rs b/src/exception.rs
@@ -10,7 +10,7 @@ use crate::{sys, JSException, JSString, JSValue};
 
 impl JSException {
     /// Return the underlying value backing the exception.
-    pub fn underlying_value(&self) -> &JSValue {
+    pub const fn underlying_value(&self) -> &JSValue {
         &self.value
     }
 
diff --git a/src/object.rs b/src/object.rs
@@ -14,7 +14,7 @@ impl JSObject {
     /// # Safety
     ///
     /// Ensure `raw` is valid.
-    pub unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSObjectRef) -> Self {
+    pub const unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSObjectRef) -> Self {
         Self {
             raw,
             value: JSValue::from_raw(ctx, raw),
diff --git a/src/typed_array.rs b/src/typed_array.rs
@@ -13,7 +13,7 @@ impl JSTypedArray {
     /// # Safety
     ///
     /// Ensure `raw` is valid, and represents a typed array.
-    pub(crate) unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSObjectRef) -> Self {
+    pub(crate) const unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSObjectRef) -> Self {
         Self { raw, ctx }
     }
 
diff --git a/src/value.rs b/src/value.rs
@@ -18,7 +18,7 @@ impl JSValue {
     /// # Safety
     ///
     /// Ensure `raw` is valid.
-    pub unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSValueRef) -> Self {
+    pub const unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSValueRef) -> Self {
         Self { raw, ctx }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ impl JSContext {`
`15`	`15`	`/// # Safety`
`16`	`16`	`///`
`17`	`17`	/// Ensure `raw` is valid.
`18`		`- pub unsafe fn from_raw(raw: sys::JSGlobalContextRef) -> Self {`
	`18`	`+ pub const unsafe fn from_raw(raw: sys::JSGlobalContextRef) -> Self {`
`19`	`19`	`Self { raw }`
`20`	`20`	`}`
`21`	`21`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ use crate::{sys, JSException, JSString, JSValue};`
`10`	`10`
`11`	`11`	`impl JSException {`
`12`	`12`	`/// Return the underlying value backing the exception.`
`13`		`- pub fn underlying_value(&self) -> &JSValue {`
	`13`	`+ pub const fn underlying_value(&self) -> &JSValue {`
`14`	`14`	`&self.value`
`15`	`15`	`}`
`16`	`16`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ impl JSTypedArray {`
`13`	`13`	`/// # Safety`
`14`	`14`	`///`
`15`	`15`	/// Ensure `raw` is valid, and represents a typed array.
`16`		`- pub(crate) unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSObjectRef) -> Self {`
	`16`	`+ pub(crate) const unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSObjectRef) -> Self {`
`17`	`17`	`Self { raw, ctx }`
`18`	`18`	`}`
`19`	`19`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ impl JSValue {`
`18`	`18`	`/// # Safety`
`19`	`19`	`///`
`20`	`20`	/// Ensure `raw` is valid.
`21`		`- pub unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSValueRef) -> Self {`
	`21`	`+ pub const unsafe fn from_raw(ctx: sys::JSContextRef, raw: sys::JSValueRef) -> Self {`
`22`	`22`	`Self { raw, ctx }`
`23`	`23`	`}`
`24`	`24`