Skip to content

Track lines and columns in error messages #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmmv merged 20 commits into from
Oct 24, 2022
Merged

Track lines and columns in error messages #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
885ffb1
Track the current file position in the CharReader
jmmv Oct 13, 2022
8995809
Track the position of every token in the input
jmmv Oct 13, 2022
c51d65d
Extend parser errors to show failing positions
jmmv Oct 14, 2022
116a429
Point block balance errors to the beginning
jmmv Oct 14, 2022
5791d43
Avoid printing Tokens via Debug
jmmv Oct 14, 2022
30e1795
Avoid printing Values via Debug
jmmv Oct 14, 2022
2b6162d
Add spans for all statement types in the AST
jmmv Oct 18, 2022
5c061a8
Pass BuiltinCallSpan to Command::exec
jmmv Oct 19, 2022
db6bb13
Wrap builtin call arguments into an ArgSpan
jmmv Oct 19, 2022
47e9a4c
Add spans for most expression types in the AST
jmmv Oct 20, 2022
b5284e5
Finish adding spans for expression types
jmmv Oct 21, 2022
ae95346
Add positions to expression spans
jmmv Oct 21, 2022
8310702
Pass FunctionCallSpans to functions
jmmv Oct 23, 2022
d7a6a35
Move Value impl to a new value.rs file
jmmv Oct 23, 2022
e1ead16
Add positions to Eval::Error
jmmv Oct 23, 2022
be8ff04
Add positions to Statement spans
jmmv Oct 24, 2022
5d4dad6
Avoid blind conversions from value to exec errors
jmmv Oct 24, 2022
fefd467
Add positions to CallError
jmmv Oct 24, 2022
2e53d90
Remove more debug types from error messages
jmmv Oct 24, 2022
a0de865
Document error message cleanups
jmmv Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ for the time being.**

* Fixed erratic insertion of newlines in existing text in the editor.

* Issue #113: Added line and column tracking to error messages for parsing
and execution errors. Also cleaned up Rust `Debug` impls that leaked
into error messages for nicer errors.

## Changes in version 0.9.0

**Released on 2022-06-05.**
Expand Down
2 changes: 1 addition & 1 deletion cli/tests/cli/interactive.err
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
endbasic: Unknown builtin HELP
endbasic: 20:1: Unknown builtin HELP
2 changes: 1 addition & 1 deletion cli/tests/lang/exec-error.err
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
endbasic: Cannot compare Integer(2) and Boolean(true) with <
endbasic: 17:6: Cannot compare 2 and TRUE with <
2 changes: 1 addition & 1 deletion cli/tests/lang/lexer-error.err
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
endbasic: Unexpected token Bad("Unexpected character in symbol: ^") in statement
endbasic: 17:1: Unexpected character in symbol: ^
2 changes: 1 addition & 1 deletion cli/tests/lang/parser-error.err
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
endbasic: No expression in IF statement
endbasic: 17:4: No expression in IF statement
2 changes: 1 addition & 1 deletion cli/tests/repl/editor.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ And now the editor displays the last-saved file name
Current program LOCAL:test.bas has unsaved changes!
[?1049h[?25l ESC Exit | <NO NAME> | Ln 1, Col 1 
[?25hP[?25l ESC Exit | <NO NAME>* | Ln 1, Col 2 [?25hR[?25l ESC Exit | <NO NAME>* | Ln 1, Col 3 [?25hI[?25l ESC Exit | <NO NAME>* | Ln 1, Col 4 [?25hN[?25l ESC Exit | <NO NAME>* | Ln 1, Col 5 [?25hT[?25l ESC Exit | <NO NAME>* | Ln 1, Col 6 [?25h [?25l ESC Exit | <NO NAME>* | Ln 1, Col 7 [?25h"[?25l ESC Exit | <NO NAME>* | Ln 1, Col 8 [?25hT[?25l ESC Exit | <NO NAME>* | Ln 1, Col 9 [?25hh[?25l ESC Exit | <NO NAME>* | Ln 1, Col 10 [?25hi[?25l ESC Exit | <NO NAME>* | Ln 1, Col 11 [?25hs[?25l ESC Exit | <NO NAME>* | Ln 1, Col 12 [?25h [?25l ESC Exit | <NO NAME>* | Ln 1, Col 13 [?25hi[?25l ESC Exit | <NO NAME>* | Ln 1, Col 14 [?25hs[?25l ESC Exit | <NO NAME>* | Ln 1, Col 15 [?25h [?25l ESC Exit | <NO NAME>* | Ln 1, Col 16 [?25ha[?25l ESC Exit | <NO NAME>* | Ln 1, Col 17 [?25h [?25l ESC Exit | <NO NAME>* | Ln 1, Col 18 [?25hn[?25l ESC Exit | <NO NAME>* | Ln 1, Col 19 [?25he[?25l ESC Exit | <NO NAME>* | Ln 1, Col 20 [?25hw[?25l ESC Exit | <NO NAME>* | Ln 1, Col 21 [?25h [?25l ESC Exit | <NO NAME>* | Ln 1, Col 22 [?25hp[?25l ESC Exit | <NO NAME>* | Ln 1, Col 23 [?25hr[?25l ESC Exit | <NO NAME>* | Ln 1, Col 24 [?25ho[?25l ESC Exit | <NO NAME>* | Ln 1, Col 25 [?25hg[?25l ESC Exit | <NO NAME>* | Ln 1, Col 26 [?25hr[?25l ESC Exit | <NO NAME>* | Ln 1, Col 27 [?25ha[?25l ESC Exit | <NO NAME>* | Ln 1, Col 28 [?25hm[?25l ESC Exit | <NO NAME>* | Ln 1, Col 29 [?25h [?25l ESC Exit | <NO NAME>* | Ln 1, Col 30 [?25hw[?25l ESC Exit | <NO NAME>* | Ln 1, Col 31 [?25hi[?25l ESC Exit | <NO NAME>* | Ln 1, Col 32 [?25ht[?25l ESC Exit | <NO NAME>* | Ln 1, Col 33 [?25hh[?25l ESC Exit | <NO NAME>* | Ln 1, Col 34 [?25h [?25l ESC Exit | <NO NAME>* | Ln 1, Col 35 [?25ha[?25l ESC Exit | <NO NAME>* | Ln 1, Col 36 [?25hn[?25l ESC Exit | <NO NAME>* | Ln 1, Col 37 [?25h [?25l ESC Exit | <NO NAME>* | Ln 1, Col 38 [?25hi[?25l ESC Exit | <NO NAME>* | Ln 1, Col 39 [?25hn[?25l ESC Exit | <NO NAME>* | Ln 1, Col 40 [?25hv[?25l ESC Exit | <NO NAME>* | Ln 1, Col 41 [?25ha[?25l ESC Exit | <NO NAME>* | Ln 1, Col 42 [?25hl[?25l ESC Exit | <NO NAME>* | Ln 1, Col 43 [?25hi[?25l ESC Exit | <NO NAME>* | Ln 1, Col 44 [?25hd[?25l ESC Exit | <NO NAME>* | Ln 1, Col 45 [?25h [?25l ESC Exit | <NO NAME>* | Ln 1, Col 46 [?25hc[?25l ESC Exit | <NO NAME>* | Ln 1, Col 47 [?25ho[?25l ESC Exit | <NO NAME>* | Ln 1, Col 48 [?25hm[?25l ESC Exit | <NO NAME>* | Ln 1, Col 49 [?25hm[?25l ESC Exit | <NO NAME>* | Ln 1, Col 50 [?25ha[?25l ESC Exit | <NO NAME>* | Ln 1, Col 51 [?25hn[?25l ESC Exit | <NO NAME>* | Ln 1, Col 52 [?25hd[?25l ESC Exit | <NO NAME>* | Ln 1, Col 53 [?25h"[?25l ESC Exit | <NO NAME>* | Ln 1, Col 54 [?25h[?25l ESC Exit | <NO NAME>* | Ln 2, Col 1 [?25hI[?25l ESC Exit | <NO NAME>* | Ln 2, Col 2 [?25hN[?25l ESC Exit | <NO NAME>* | Ln 2, Col 3 [?25hV[?25l ESC Exit | <NO NAME>* | Ln 2, Col 4 [?25hA[?25l ESC Exit | <NO NAME>* | Ln 2, Col 5 [?25hL[?25l ESC Exit | <NO NAME>* | Ln 2, Col 6 [?25hI[?25l ESC Exit | <NO NAME>* | Ln 2, Col 7 [?25hD[?25l ESC Exit | <NO NAME>* | Ln 2, Col 8 [?25h [?25l ESC Exit | <NO NAME>* | Ln 2, Col 9 [?25hL[?25l ESC Exit | <NO NAME>* | Ln 2, Col 10 [?25hI[?25l ESC Exit | <NO NAME>* | Ln 2, Col 11 [?25hN[?25l ESC Exit | <NO NAME>* | Ln 2, Col 12 [?25hE[?25l ESC Exit | <NO NAME>* | Ln 2, Col 13 [?25h[?25l ESC Exit | <NO NAME>* | Ln 3, Col 1 [?25hP[?25l ESC Exit | <NO NAME>* | Ln 3, Col 2 [?25hR[?25l ESC Exit | <NO NAME>* | Ln 3, Col 3 [?25hI[?25l ESC Exit | <NO NAME>* | Ln 3, Col 4 [?25hN[?25l ESC Exit | <NO NAME>* | Ln 3, Col 5 [?25hT[?25l ESC Exit | <NO NAME>* | Ln 3, Col 6 [?25h [?25l ESC Exit | <NO NAME>* | Ln 3, Col 7 [?25h"[?25l ESC Exit | <NO NAME>* | Ln 3, Col 8 [?25hS[?25l ESC Exit | <NO NAME>* | Ln 3, Col 9 [?25hh[?25l ESC Exit | <NO NAME>* | Ln 3, Col 10 [?25ho[?25l ESC Exit | <NO NAME>* | Ln 3, Col 11 [?25hu[?25l ESC Exit | <NO NAME>* | Ln 3, Col 12 [?25hl[?25l ESC Exit | <NO NAME>* | Ln 3, Col 13 [?25hd[?25l ESC Exit | <NO NAME>* | Ln 3, Col 14 [?25h [?25l ESC Exit | <NO NAME>* | Ln 3, Col 15 [?25hn[?25l ESC Exit | <NO NAME>* | Ln 3, Col 16 [?25ho[?25l ESC Exit | <NO NAME>* | Ln 3, Col 17 [?25ht[?25l ESC Exit | <NO NAME>* | Ln 3, Col 18 [?25h [?25l ESC Exit | <NO NAME>* | Ln 3, Col 19 [?25hb[?25l ESC Exit | <NO NAME>* | Ln 3, Col 20 [?25he[?25l ESC Exit | <NO NAME>* | Ln 3, Col 21 [?25h [?25l ESC Exit | <NO NAME>* | Ln 3, Col 22 [?25hr[?25l ESC Exit | <NO NAME>* | Ln 3, Col 23 [?25he[?25l ESC Exit | <NO NAME>* | Ln 3, Col 24 [?25ha[?25l ESC Exit | <NO NAME>* | Ln 3, Col 25 [?25hc[?25l ESC Exit | <NO NAME>* | Ln 3, Col 26 [?25hh[?25l ESC Exit | <NO NAME>* | Ln 3, Col 27 [?25he[?25l ESC Exit | <NO NAME>* | Ln 3, Col 28 [?25hd[?25l ESC Exit | <NO NAME>* | Ln 3, Col 29 [?25h"[?25l ESC Exit | <NO NAME>* | Ln 3, Col 30 [?25h[?25l ESC Exit | <NO NAME>* | Ln 4, Col 1 [?25h[?1049lThis is a new program with an invalid command
ERROR: Unknown builtin INVALID
ERROR: 2:1: Unknown builtin INVALID
Done.
Current program has unsaved changes and has never been saved!
End of input by CTRL-D
10 changes: 5 additions & 5 deletions cli/tests/repl/help.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ Output from HELP GPIO_CLEAR:

Output from HELP GPIO_SETUP:

GPIO_SETUP pin% mode$
GPIO_SETUP pin%, mode$

Configures a GPIO pin for input or output.

Expand All @@ -464,7 +464,7 @@ Output from HELP GPIO_SETUP:

Output from HELP GPIO_WRITE:

GPIO_WRITE pin% value?
GPIO_WRITE pin%, value?

Sets the state of a GPIO pin.

Expand Down Expand Up @@ -531,7 +531,7 @@ Output from HELP LOCATE:

Output from HELP LOGIN:

LOGIN username$ [password$]
LOGIN username$[, password$]

Logs into the user's account.

Expand Down Expand Up @@ -646,7 +646,7 @@ Output from HELP SAVE:

Output from HELP SHARE:

SHARE filename$ [, acl1$, .., aclN$]
SHARE filename$[, acl1$, .., aclN$]

Displays or modifies the ACLs of a file.

Expand Down Expand Up @@ -688,7 +688,7 @@ Output from HELP SLEEP:

Output from HELP UNMOUNT:

UNMOUNT drive_name
UNMOUNT drive_name$

Unmounts the given drive.

Expand Down
2 changes: 1 addition & 1 deletion cli/tests/repl/interactive.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
For a guided tour, type: LOAD "DEMOS:/TOUR.BAS": RUN

Got 123 from stdin
ERROR: Unknown builtin FOOBAR
ERROR: 1:1: Unknown builtin FOOBAR
Continuing
End of input by CTRL-D
Loading