Open
Conversation
jmmv
reviewed
Dec 9, 2021
Collaborator
jmmv
left a comment
jmmv
left a comment
There was a problem hiding this comment.
Per the new contributing notes, could you update this to add an entry to NEWS.md and have a proper summary/description? Otherwise, it seems good to go! Thanks a lot!
|
|
||
| run_editor("abc\nabc\n", "abcx\nabc\n", cb, ob); | ||
| } | ||
| #[test] |
Collaborator
There was a problem hiding this comment.
nit: Make sure there is a blank line between functions, here and below.
Protowalker
force-pushed
the
editorMove
branch
from
ef00344 to
ad5bd7d
Compare
Author
|
@jmmv after an incredibly annoying experience learning how to rebase I have successfully done those things |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.