Skip to content

Add lines and columns for errors (#113)#142

Closed
Protowalker wants to merge 5 commits intoendbasic:masterfrom
Protowalker:tokspan
Closed

Add lines and columns for errors (#113)#142
Protowalker wants to merge 5 commits intoendbasic:masterfrom
Protowalker:tokspan

Conversation

@Protowalker
Copy link
Copy Markdown

@Protowalker Protowalker commented Dec 4, 2021

Addresses #113

@Protowalker Protowalker changed the title Add lines and columns for errors Add lines and columns for errors (#113) Dec 4, 2021
@jmmv
Copy link
Copy Markdown
Collaborator

jmmv commented Dec 9, 2021

I know this is still a draft, but it's looking pretty good!

However, this needs updating the tests. Also, I'm seeing a lot of code changes, but I don't think the new information is bubbled up in any error messages yet?

@Protowalker
Copy link
Copy Markdown
Author

Protowalker commented Dec 9, 2021

@jmmv Yup, gonna add tests when I next get the chance to work on this. Currently nothing actually makes use of the span information yet, correct -- I was done for the day when writing and knew that I would take forever to add error messages :) (not to mention all the self-bikeshedding I'd do)

@Protowalker Protowalker mentioned this pull request Dec 9, 2021
@jmmv
Copy link
Copy Markdown
Collaborator

jmmv commented Oct 24, 2022

Thanks for your contribution. I took inspiration in your first change and started doing this... but adding line and column numbers to errors turned out to be a gargantuan task. Adding these for parser errors was easy, but propagating the details for runtime errors was a very different story. In any case, this is now coming up in #191 and should be ready for merge soon.

@jmmv jmmv closed this Oct 24, 2022
@Protowalker Protowalker deleted the tokspan branch November 1, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants