This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Implement multi-column constraints.#73
Closed
AndTheDaysGoBy wants to merge 1 commit intoencode:masterfrom
Closed
Conversation
AndTheDaysGoBy
commented
Aug 2, 2020
Author
There was a problem hiding this comment.
Actually, looking at the stack-trace, it makes sense sqlalchemy.exc.IntegrityError isn't caught, I think, because sqlalchemy isn't used at all? The flow is orm/models.py to databases/core.py to (due to my use case) databases/backends/sqlite.py to aiosqlite/cursor.py to aiosqlite/core.py.
Edit:
OK, seems that there is an upstream issue for this: encode/databases#162.
| await Channel.objects.create(name='PBS', number=2) | ||
| await Channel.objects.create(name='CSPAN', number=2) | ||
|
|
||
| from sqlite3 import IntegrityError |
Author
There was a problem hiding this comment.
I was using sqlite. In theory sqlalchemy.exc.IntegrityError should catch this (I believe). However, the exception raised within aiosqlite could only be caught by sqlite3.IntegrityError.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created for #72.
This allows for the pass-through of table arguments to the underlying sqlalchemy table. In particular, the passing of
UniqueConstraint.This PR should not be considered complete, but requesting input. Two subjects of particular concern are:
UniqueConstraintfromsqlalchemy.schemawhen used. Is this fine? Theoretically this multi-column uniqueness shouldn't be as prevalent as single column uniqueness (which only requires passingunique=True). Thus, perhaps it makes sense to necessitate directly reference to sqlalchemy in these rare cases.from sqlite3 import IntegrityError. This is what I used because the exception raised byaiosqliteis not encapsulated byfrom sqlalchemy.exc import IntegrityError. Thus, I question how to deal with the issue thataiosqlite'sIntegrityErrorisn't being caught using a cross-DB solution.More on the second point, I don't know if that means I should open up an issue with
aiosqlite.