Rely on codecov for 100% project coverage#264
Merged
Conversation
Contributor
Author
|
cc @tomchristie looks like codecov needs API tokens for this public repo now?? Not sure what that's about. |
Contributor
|
codecov is currently broken: codecov/codecov-bash#198 (I noticed this on two other projects) |
Contributor
Author
|
Thanks @pquentin! |
Contributor
|
... and it's back! |
Contributor
Author
|
Not back for us apparently :( |
Contributor
|
Well, the part that was broken got fixed, see https://codecov.io/gh/encode/httpx/tree/9229e4591f12b13aa1524a525519e291d3574b72 which reports 100%. I don't know why there was no comment here though! |
Contributor
Author
|
I think I may merge this and see if that solves our codecov comment problem? Either way all maintainers (@encode/httpx-maintainers) be aware of coverage check codecov on each PR before merging until this issue is resolved. |
Kludex
referenced
this pull request
in pydantic/httpx2
May 11, 2026
* Bump twine from 3.2.0 to 3.3.0 Bumps [twine](https://github.com/pypa/twine) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/pypa/twine/releases) - [Changelog](https://github.com/pypa/twine/blob/master/docs/changelog.rst) - [Commits](pypa/twine@3.2.0...3.3.0) Signed-off-by: dependabot[bot] <support@github.com> * Update requirements.txt Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom Christie <tom@tomchristie.com> Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As can be seen in #263 we can't have all code be covered by Python 3.6 and I don't want to mark that large chunk of code as
no cover.