Add ConcurrencyBackend.start_tls()#263
Merged
Merged
Conversation
Contributor
Author
|
It looks like there were a lot of changes related to import order in this PR from me running |
Co-Authored-By: Florimond Manca <florimond.manca@gmail.com>
Contributor
Author
|
Codecov is saying 100% for this branch: https://codecov.io/gh/encode/httpx/pull/263 |
florimondmanca
self-requested a review
August 23, 2019 12:07
florimondmanca
suggested changes
Aug 23, 2019
florimondmanca
left a comment
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me — just a note about generalizing the TLS assertion 🙏.
Contributor
Author
|
Thanks for the review @florimondmanca! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This primitive will be used for HTTP CONNECT tunnel proxies to apply TLS onto either a raw socket stream or an existing TLS stream.