Suppress binary output on the command line.#2076
Merged
lovelydinosaur merged 1 commit intoencode:masterfrom Feb 9, 2022
waterfountain1996:binary-output
Merged
Suppress binary output on the command line.#2076lovelydinosaur merged 1 commit intoencode:masterfrom waterfountain1996:binary-output
lovelydinosaur merged 1 commit intoencode:masterfrom
waterfountain1996:binary-output
Conversation
lovelydinosaur
changed the title
lovelydinosaur
approved these changes
Feb 9, 2022
Contributor
|
Great - thanks! |
Contributor
|
Verified this to myself with the following... # Nice clean virtualenv. Be explicit about which version of Python.
$ python3.9 -m venv venv
# Install from the `binary-output` branch on your repo.
$ venv/bin/pip install git+https://github.com/waterfountain1996/httpx.git@binary-output
# Also pull in the optional dependancies. Not sure I can do that with the URL style above?
$ venv/bin/pip install httpx[cli]
# Run it and check...
$ venv/bin/httpx https://cataas.com/cat
HTTP/1.1 200 OK
Server: nginx/1.12.2
Date: Wed, 09 Feb 2022 15:33:14 GMT
Content-Type: image/jpeg
Content-Length: 35069
Connection: keep-alive
Access-Control-Allow-Origin: *
Access-Control-Allow-Headers: X-Requested-With, Content-Type, Accept, Origin, Authorization
Access-Control-Allow-Methods: GET, POST, PUT, DELETE, OPTIONS
Cache-Control: public, max-age=30
ETag: 1644379259564
<35069 bytes of binary data> |
Contributor
|
Ah here we go... pypa/pip#6548 Using the following would install from your branch, and include the optional dependancies. $ venv/bin/pip install "httpx[cli] @ git+https://github.com/waterfountain1996/httpx.git@binary-output" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2049
Changed print_response to simply display the content length of a binary response.
get_lexer_for_responsereturns 'Text only' for aContent-Type: text/...response, so it will be properly displayed usingrich.syntax.Syntax. Those responses which do not get a corresponding lexer are considered binary and their output is suppressed.To make the tests pass I had to add another route to the test server that would return a binary response. Feel free to point it out if there's another way to do it.