Fix Headers.update to correctly handle repeated headers#2038
Merged
adriangb merged 6 commits intoencode:masterfrom Jan 21, 2022
Merged
Fix Headers.update to correctly handle repeated headers#2038adriangb merged 6 commits intoencode:masterfrom
adriangb merged 6 commits intoencode:masterfrom
Conversation
lovelydinosaur
approved these changes
Jan 21, 2022
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Took a little while to convince myself, but yes.
Very nice, thank you @adriangb.
lovelydinosaur
changed the title
Contributor
|
Retitled issue very slightly for neatness & consistency. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two tests were failing beforehand