Skip the http2 cancellation tests if they fail.#803
Merged
lovelydinosaur merged 1 commit intoencode:masterfrom Sep 15, 2023
Merged
Skip the http2 cancellation tests if they fail.#803lovelydinosaur merged 1 commit intoencode:masterfrom
lovelydinosaur merged 1 commit intoencode:masterfrom
Conversation
Contributor
|
Yep. Flaky async cancellation tests should be marked |
lovelydinosaur
approved these changes
Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now tests randomly fail, which in some places makes development hard (see #756).
Local testing can randomly fail, and GitHub actions can also fail.
For example, 3.11 tests fail, causing other actions to be interrupted.
Let's just skip these tests for now and remove the "@pytest.mark.xfail" flag in the pull request, which will resolve #756
Checklist