Support sni_hostname extension with SOCKS proxy#773
Closed
Allgot wants to merge 7 commits intoencode:masterfrom
Closed
Support sni_hostname extension with SOCKS proxy#773Allgot wants to merge 7 commits intoencode:masterfrom
sni_hostname extension with SOCKS proxy#773Allgot wants to merge 7 commits intoencode:masterfrom
Conversation
Contributor
Author
|
Sorry for the confusing PR. I created a new branch from the HEAD by mistake. I would close this PR right now, then create new one properly. Sorry. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
sni_hostnameextension with SOCKS proxy.This is a complementary update of Add sni hostname extension #696.
Co-authored-by: Tom Christie tom@tomchristie.com
Summary
A new extension,
sni_hostnamehas enalbed users to specify the hostname which would be used during TLS handshake. However, the update was inconsistent, resulting in the incomplete extension. Currently, thesni_hostnameextension are not handled if SOCKS proxy is in use. This PR would bridge this gap.Checklist