It appears we can't release this without the #757

It appears we can't release this without the #757

Could you explain what you mean here?

Could you explain what you mean here?

Now that the tests are broken, I don't think it's a good idea to release them.
They randomly fail.

Ah yep.

Linking here to our currently flaky test case.

@karosis88 Are you ok to ship #727 as part of 0.18.0?

according to encode/httpx#2801 (comment), the todo list also include #757

Okay, here's how our CHANGELOG for this version looks at this point in time...

• Add support for HTTPS proxies. (Add support for HTTPS proxies (available to trio/asyncio) #745, # 786)
• Handle sni_hostname extension with SOCKS proxy. (Support sni_hostname extension with SOCKS proxy. #774)
• Change the type of Extensions from Mapping[Str, Any] to MutableMapping[Str, Any]. (Change type of Extensions #762)
• Handle HTTP/1.1 half-closed connections gracefully. (Handle HTTP/1.1 half-closed connections gracefully. #641)
• Drop Python 3.7 support. (Drop Python 3.7 support #727)

The most substantial other bits of work that we have on the table right now are...

• Some remaining issues around async cancellations. (Ensure HTTP/2 connections are gracefully closed on async cancellation #756, Handle asynchronous cancellations for HTTPConnection instances #785)
• Explicit proxy configuration between forwarding/connect. (Support force-forwarding and force-tunneling #735)

I'd probably suggest that we press on with a 0.18.0 release as we currently stand...

• The async cancellation issues are quite involved, and I don't want us to be time pressured in resolving them.
• This will give us time for our users to test our HTTPS proxy support before we add any further functionality there.

There's also already plenty more for us to wrap in an httpx 0.25 release - encode/httpx#2801 once we've got this httpcore release done.

Thoughts, team?

There is already an easy solution in #757 for our async cancellations. I suggest that we include that simple modification, but if you don't like it, I am fine with this changelog.

I am fine with this changelog.

This would be my preference yes.

To my eyes #757 is too awkwardly gnarly to just wave on through, I'd like us to slow down on that and get it comprehensively correct.

In addition, I will gladly include #734 to this release. It appears to be a part of #722.

In addition, I will gladly include #734 to this release. It appears to be a part of #722.

IMO they are separated from each other, But yes, I agree to include it in 0.18.0

@karosis88 karosis88 requested a review from tomchristie

I'm happy to approve this, once the description matches the CHANGELOG.

I will add a release date after your review.

Let's get a release draft ready before we merge this...

Can I draft a new release?

I don't recall if you're able to do that with the @encode/maintainers permissions.

In any case I've created one here... https://github.com/encode/httpcore/releases/tag/untagged-71ea7b9ccfc1bfebd276