Conversation
Contributor
Author
Contributor
|
Yup, this is a good point to make a release. |
Contributor
Author
|
Is there anything else we'd like to see in this release? |
Contributor
No I think this is a good cutting point. |
Contributor
|
I have a release draft here... https://github.com/encode/httpcore/releases/tag/untagged-1c6e6829784084137660 Does that all look correct to you? |
Contributor
Author
|
Yes, this appears to be correct to me. Should I include the date in the changelog? |
Contributor
|
Yep. |
lovelydinosaur
approved these changes
Jul 4, 2023
Contributor
I probably should have requested that we also don't merge until release date. 😅 S'all good tho. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
0.17.3
trace callbackis passed to an asynchronous request or an asynchronoustrace callbackis passed to a synchronous request. (Add exceptions for invalid trace callback #717)