Skip to content

Version 0.17.2#697

Merged
karpetrosyan merged 4 commits intoencode:masterfrom
karpetrosyan:version-0.17.2
May 23, 2023
Merged

Version 0.17.2#697
karpetrosyan merged 4 commits intoencode:masterfrom
karpetrosyan:version-0.17.2

Conversation

@karpetrosyan
Copy link
Contributor

@karpetrosyan karpetrosyan commented May 23, 2023 •
edited by lovelydinosaur
Loading

0.17.2 (May 23th, 2023)

@karpetrosyan
Copy link
Contributor Author

karpetrosyan commented May 23, 2023

Also we can include #662 to this release and resolve encode/httpx#2635

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented May 23, 2023

Also we can include #662 to this release and resolve encode/httpx#2635

Gotcha - I'll let you lead on this, I'm happy to approve this once youre ready.

@karpetrosyan
Copy link
Contributor Author

karpetrosyan commented May 23, 2023

Also we can include #662 to this release and resolve encode/httpx#2635

Gotcha - I'll let you lead on this, I'm happy to approve this once youre ready.

Count on me, I'm ready!

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented May 23, 2023 •
edited
Loading

Okay, does this release draft look correct?... https://github.com/encode/httpcore/releases/tag/untagged-21bae35c0de10a5a336f

/cc @encode/maintainers

@musale
Copy link

musale commented May 23, 2023 •
edited
Loading

Okay, does this release draft look correct?... https://github.com/encode/httpcore/releases/tag/untagged-21bae35c0de10a5a336f

/cc @encode/maintainers

Add #662. Otherwise, looks correct.

@karpetrosyan
Copy link
Contributor Author

karpetrosyan commented May 23, 2023

Let's also put the significant changes at the top, and I believe it's ready.

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented May 23, 2023

Add #662. Otherwise, looks correct.

Thanks! I needed to double check that. We've got it listed under PR #668.

Let's also put the significant changes at the top, and I believe it's ready.

I've updated it in line with your commit 734ba02.

lovelydinosaur
lovelydinosaur approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we're good on this.

@karpetrosyan karpetrosyan merged commit be4035d into encode:master May 23, 2023
@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented May 23, 2023

thanks so much @karosis88, @musale. 🙏🏼

i've approved the action... https://github.com/encode/httpcore/actions/runs/5056372195 ... and we have deployed... https://pypi.org/project/httpcore/0.17.2/ 😎

@karpetrosyan
Copy link
Contributor Author

karpetrosyan commented May 23, 2023

Good job!

@lovelydinosaur lovelydinosaur mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lovelydinosaur lovelydinosaur lovelydinosaur approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karpetrosyan @lovelydinosaur @musale