This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Conversation
PrettyWood
suggested changes
Aug 26, 2021
Contributor
There was a problem hiding this comment.
Thanks for taking care of this
2 remarks:
- I'm not sure it is fix anymore since sqlachemy was already pinned. IMO it's more a feature "support sqlachemy 1.4". WDYT?
- with this in mind should it be a 0.5.0 instead of a patched version since there is a breaking change?
Edit: sorry I'm on my phone travelling. Hard to type with those fat fingers
Contributor
Author
@PrettyWood I agree about the first point. |
Contributor
|
I reckon it's easier to have 0.4 only for sqlachemy<=1.3 Having 0.4.3 for 1.3 and 0.4.4 for 1.4 feels weird to me. Maybe I'm biased 🤷♂️ |
Contributor
Author
|
@PrettyWood Makes sense, I'll change that. |
|
Nice work! Re, the versions: https://python-poetry.org/docs/dependency-specification/#caret-requirements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.