Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

option pool_recycle #233

Merged
vmarkovtsev merged 6 commits into from
Aug 11, 2020
Merged

option pool_recycle #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
16e0502
option pool_recycle
igengmei Aug 6, 2020
cceda38
#233 allow setting pool_recycle
igengmei Aug 11, 2020
81bd5ae
#233 typo error
igengmei Aug 11, 2020
7ab6d5a
#233 typo error
igengmei Aug 11, 2020
70238c1
#233 reformat code
igengmei Aug 11, 2020
6c2eab0
Merge branch 'master' into master
kulame Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.vscode/
*.pyc
test.db
.coverage
Expand Down
3 changes: 3 additions & 0 deletions databases/backends/mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,15 @@ def _get_connection_kwargs(self) -> dict:
kwargs = {}
min_size = url_options.get("min_size")
max_size = url_options.get("max_size")
pool_recycle = url_options.get("pool_recycle")
ssl = url_options.get("ssl")

if min_size is not None:
kwargs["minsize"] = int(min_size)
if max_size is not None:
kwargs["maxsize"] = int(max_size)
if pool_recycle is not None:
kwargs["pool_recycle"] = int(pool_recycle)
if ssl is not None:
kwargs["ssl"] = {"true": True, "false": False}[ssl.lower()]

Expand Down
6 changes: 6 additions & 0 deletions tests/test_connection_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ def test_mysql_explicit_ssl():
assert kwargs == {"ssl": True}


def test_mysql_pool_recycle():
backend = MySQLBackend("mysql://localhost/database?pool_recycle=20")
kwargs = backend._get_connection_kwargs()
assert kwargs == {"pool_recycle": 20}


def test_aiopg_pool_size():
backend = AiopgBackend(
"postgresql+aiopg://localhost/database?min_size=1&max_size=20"
Expand Down