This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Build queries before acquiring the lock #199
Merged
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The checks are actually successful, that's the GitHub's CI internals which are not. |
Contributor
|
@vmarkovtsev Yuck. Okay, let's see if we can re-run that. Having just moved off travis, I'm really hoping GitHub actions is decently robust. |
lovelydinosaur
approved these changes
Apr 28, 2020
Contributor
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the query takes some time, especially if it is big. We hit real performance problems in prod because of that (hundreds of bound parameters, etc.).