Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Return correct values from PostgreSQL record when columns have identical name #173

Merged
lovelydinosaur merged 2 commits into from
Apr 29, 2020
Merged

Return correct values from PostgreSQL record when columns have identical name #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9a8f82
Make sure the correct values are returned from a postgres record
rzane Mar 13, 2020
918cbb2
Merge branch 'master' into fix-incorrect-values
lovelydinosaur Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions databases/backends/postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ def __init__(
self._column_map_int[idx] = (idx, datatype)
self._column_map_full[str(column[0])] = (idx, datatype)

def values(self) -> typing.ValuesView:
return self._row.values()

def __getitem__(self, key: typing.Any) -> typing.Any:
if len(self._column_map) == 0: # raw query
return self._row[tuple(self._row.keys()).index(key)]
Expand Down
16 changes: 16 additions & 0 deletions tests/test_databases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,22 @@ async def test_results_support_column_reference(database_url):
assert results[0][custom_date.c.published] == today


@pytest.mark.parametrize("database_url", DATABASE_URLS)
@async_adapter
async def test_result_values_allow_duplicate_names(database_url):
"""
The values of a result should respect when two columns are selected
with the same name.
"""
async with Database(database_url) as database:
async with database.transaction(force_rollback=True):
query = "SELECT 1 AS id, 2 AS id"
row = await database.fetch_one(query=query)

assert list(row.keys()) == ["id", "id"]
assert list(row.values()) == [1, 2]


@pytest.mark.parametrize("database_url", DATABASE_URLS)
@async_adapter
async def test_fetch_one_returning_no_results(database_url):
Expand Down