This repository was archived by the owner on Aug 19, 2025. It is now read-only.
Return correct values from PostgreSQL record when columns have identical name #173
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzane
force-pushed
the
fix-incorrect-values
branch
from
22a8cc9 to
ed66340
Compare
rzane
force-pushed
the
fix-incorrect-values
branch
from
ed66340 to
c9a8f82
Compare
vmarkovtsev
approved these changes
Apr 29, 2020
lovelydinosaur
approved these changes
Apr 29, 2020
Contributor
|
Fantastic, thanks! @rzane Since this is your first approved PR, you're welcome to an invite to Thanks for your time on this. 😀 |
Contributor
|
@tomchristie did you mean myself or Ray?.. |
Contributor
|
I meant Ray, yup. We're trying to move to an open doors policy of "invites to the maintainers team for anyone who gets a PR through" |
Contributor
|
All right 👍 I wonder if #199 counts in my case, too. |
Contributor
|
Yup absolutely, just not always succeeding in tracking it! 😬 |
lovelydinosaur
changed the title
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fairly common to select two columns that are assigned the same name. In those scenarios, you can't really rely on the dictionary version of the record, but you get the values by their index.
Previously, when two columns with the same name were selected, the PostgreSQL Record would return only the first column's value.
This PR fixes that bug and returns the correct values.