Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: emscripten-core/emsdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: emscripten-core/emsdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: activated_path_extra
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jul 23, 2026

  1. Support extra activated path via activated_path_extra

    In newer versions of emscripten, executables are being moved into a
    `bin` subdirectory instead of residing in the root directory. To enable
    `emsdk` to add `bin` to `PATH` while maintaining backwards
    compatibility with older emscripten releases, this change introduces an
    optional `activated_path_extra` property on `Tool`.
    
    When configuring `PATH` or checking environment activation,
    `activated_path_extra` is checked and included in addition to the
    primary `activated_path` if the directory exists on disk.
    
    Alternatives considered:
    - Delimited strings (e.g. semicolon or colon separated) in
      `activated_path`: Rejected because colon (`:`) conflicts with
      Windows drive letters (`C:\...`), and splitting string paths would
      require updating all call sites that expect `activated_path` to be a
      single directory (e.g., when writing `emscripten-version.txt`).
    - JSON arrays in `activated_path`: While this avoids delimiter
      collisions on Windows, making `activated_path` polymorphic (either a
      string or list) would similarly complicate call sites requiring a
      single root directory.
    - Hardcoded directory checking: Dynamically checking if a `bin`
      subdirectory exists in Python code was rejected to avoid excessive
      special-case tool checks in `emsdk.py`.
    sbc100 committed Jul 23, 2026
    Configuration menu
    Copy the full SHA
    f496917 View commit details
    Browse the repository at this point in the history
Loading