[embind] Allow awaiting Promises in non-Promise coroutines & catching Promise C++ exceptions#26195
Draft
stevenwdv wants to merge 3 commits intoemscripten-core:mainfrom
Draft
[embind] Allow awaiting Promises in non-Promise coroutines & catching Promise C++ exceptions#26195stevenwdv wants to merge 3 commits intoemscripten-core:mainfrom
stevenwdv wants to merge 3 commits intoemscripten-core:mainfrom
Conversation
…ipten-core#26064), allow catching Promise C++ exceptions (closes emscripten-core#25396) Still crashes on `test_embind_val_coro_catch_cpp_exception`, not sure why. TODO: What to do on rejection in the !__cpp_exceptions case in a non-Promise coroutine?
sbc100
changed the title
Contributor
Author
|
Btw, if anyone knows why the rethrow of the |
Contributor
Author
|
The cause of the crash seems to be #26213 |
I'll not terminate here so non-C++ exceptions still propagate to `await_resume`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26064
Closes #25396
Still crashes on
test_embind_val_coro_catch_cpp_exception,not sure whydue to #26213.TODO:
What to do on rejection in the!__cpp_exceptionscase in a non-Promise coroutine?await_resumeanyway.And should a non-C++ exception immediately reject a Promise since we cannot catch it (Allow catching JavaScript exceptions from C++ #11496)? Can we even distinguish C++ exceptions from non-C++ ones?