Fix __async decorators in libwasmfs_opfs.js#26026
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Fix __async decorators in libwasmfs_opfs.js#26026sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
For functions that are unconditionally declared as `async` we should also unconditionally mark them as `__async`. There are two function that are conditionally `async` and in these two cases the `__async` decorator should also be conditional.
Collaborator
Author
|
This work is kind of a followup to #20289 |
tlively
reviewed
Jan 2, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Is it possible to write a test for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For functions that are unconditionally declared as
asyncwe shouldalso unconditionally mark them as
__async. There are two functionthat are conditionally
asyncand in these two cases the__asyncdecorator should also be conditional.