[embind] Add support for argument policies to val methods.#26020
Open
brendandahl wants to merge 1 commit intoemscripten-core:mainfrom
Open
[embind] Add support for argument policies to val methods.#26020brendandahl wants to merge 1 commit intoemscripten-core:mainfrom
brendandahl wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
This change adds support for using argument policies with val::set, val::operator(), val::call, val::new_, and the val constructor. Previously, these methods used default behavior (usually copy) or required manual handling. Now policies like policy::take_ownership or policy::reference can be used directly to control how values are passed between C++ and JS. See test/embind/test_val.cpp for usage examples. Fixes emscripten-core#25412
Collaborator
Author
|
Another idea I've been toying with is to rely more on the C++ semantics. i.e. values are moved if possible, otherwise they're copied. Pointers would be how you reference an object. The downside of that approach is it doesn't really signal whether JS should delete the object or it's managed by C++. |
Contributor
I have a couple questions about this:
|
Collaborator
Author
|
Contributor
|
Thanks, that clarifies it more! Does that mean that for (non-pointer) rvalues move will become the default? (I hope so) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for using argument policies with val::set, val::operator(), val::call, val::new_, and the val constructor.
Previously, these methods used default behavior (usually copy) or required manual handling. Now policies like policy::take_ownership or policy::reference can be used directly to control how values are passed between C++ and JS.
See test/embind/test_val.cpp for usage examples.
Fixes #25412