Skip to content

Update closure-compiler to 20251216.0.0#26015

Open
michaelgiraldo wants to merge 6 commits intoemscripten-core:mainfrom
michaelgiraldo:closure-bump-20251216
Open

Update closure-compiler to 20251216.0.0#26015
michaelgiraldo wants to merge 6 commits intoemscripten-core:mainfrom
michaelgiraldo:closure-bump-20251216

Conversation

@michaelgiraldo
Copy link

@michaelgiraldo michaelgiraldo commented Dec 28, 2025 •
edited
Loading

Supersedes #24679.

Context

  • Closure 20251216 updates externs/typing, which triggers -Werror=closure failures around Atomics.waitAsync (Promise typing) and makes some local externs redundant.

Changes

  • Bump google-closure-compiler to 20251216.0.0.
  • Remove duplicate externs now provided by Closure (WebAssembly.Global, Symbol.dispose).
  • Adjust Atomics.waitAsync extern typing and add targeted @Suppress {checkTypes} where Promise.value is consumed (libatomic/libpthread/libwasm_worker).
  • Rebaseline codesize expectations after the compiler update.
  • Simplify WebGPU externs detection; add TODO to remove workaround once Dawn issue is fixed.

Tests

  • source /path/to/emsdk_env.sh && EM_CONFIG=/path/to/.emscripten test/runner --rebaseline codesize --cores=1
  • source /Users/mg/emdsdk_google/emsdk/emsdk_env.sh && EM_CONFIG=/Users/mg/emdsdk_google/emsdk/.emscripten EMTEST_BROWSER='"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" --enable-unsafe-webgpu --enable-features=WebGPU --use-angle=metal' test/runner --cores=1 --no-browser-auto-config browser_2gb.test_webgpu_basic_rendering_closure

Notes

  • Tested on macOS arm64 with emsdk sdk-main-64bit built from source.
  • Codesize diffs are expected with the Closure version bump.
  • Local run warns about missing posixtestsuite submodule; codesize suite does not depend on it.

Upstream

Copilot AI review requested due to automatic review settings December 28, 2025 05:54
Copilot AI reviewed Dec 28, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the google-closure-compiler dependency from version 20240317.0.0 to 20251216.0.0 and removes duplicate extern definitions that are now provided natively by the newer Closure Compiler version.

  • Updates google-closure-compiler to version 20251216.0.0
  • Removes duplicate externs for Atomics.waitAsync and WebAssembly.Global
  • Updates transitive dependencies including vinyl (2.2.1 → 3.0.1) and replace-ext (1.0.1 → 2.0.0)

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/closure-externs/closure-externs.js Removes duplicate extern definitions for Atomics.waitAsync and WebAssembly.Global that are now provided by the updated Closure Compiler
package.json Updates google-closure-compiler version from 20240317.0.0 to 20251216.0.0
package-lock.json Updates google-closure-compiler and its dependencies, including new platform-specific binaries (linux-arm64, macos) and updated transitive dependencies (vinyl 3.0.1, replace-ext 2.0.0, and new dependencies like streamx, teex, b4a)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sbc100
sbc100 reviewed Dec 28, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to remember that I didn't land #24679 because it contained some code size regressions that we wanted addressed before we landed it.

Are the regressions in this change less serious than in #24679?

Is there any particular reason you want this upgrade? i.e. is there some feature of closure compiler you want?

@michaelgiraldo
Copy link
Author

michaelgiraldo commented Dec 28, 2025

Upstream issue filed: https://issues.chromium.org/issues/472022911
(Closure warnings from webgpu-externs.js missing Symbol.iterator on GPUSupportedFeatures/WGSLLanguageFeatures; Emscripten currently masks with webgpu-externs-fixes.js.)

@michaelgiraldo
Copy link
Author

michaelgiraldo commented Dec 29, 2025

Addressed review: merged @Suppress tag into Atomics.waitAsync JSDoc in src/lib/libatomic.js.

Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 66 out of 67 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@michaelgiraldo
Copy link
Author

michaelgiraldo commented Dec 31, 2025 •
edited
Loading

Dawn commit has passed code review https://dawn-review.googlesource.com/c/dawn/+/282535

Upstream issue filed: https://issues.chromium.org/issues/472022911 (Closure warnings from webgpu-externs.js missing Symbol.iterator on GPUSupportedFeatures/WGSLLanguageFeatures; Emscripten currently masks with webgpu-externs-fixes.js.)

@sbc100
Copy link
Collaborator

sbc100 commented Jan 2, 2026

Did you mean to close this PR?

@michaelgiraldo michaelgiraldo reopened this Jan 3, 2026
@michaelgiraldo
Copy link
Author

michaelgiraldo commented Jan 3, 2026

@sbc100 , I did not intent to close the PR, it has been reopened

@michaelgiraldo
Copy link
Author

michaelgiraldo commented Jan 12, 2026

@sbc100 upstream DAWN change has been merged and marked as fixed. https://issues.chromium.org/issues/472022911

I will update code as need later this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbc100 sbc100 sbc100 left review comments

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelgiraldo @sbc100