Skip to content

Commit e17dd32

Browse files
committed
Refactor HealthCheckTest
1 parent 5c99b29 commit e17dd32

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

‎metrics/src/test/java/com/baeldung/metrics/healthchecks/HealthCheckTest.java‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
package com.baeldung.metrics.healthchecks;
22

3-
import static org.hamcrest.CoreMatchers.equalTo;
4-
import static org.junit.Assert.assertThat;
3+
import com.codahale.metrics.health.HealthCheck;
4+
import com.codahale.metrics.health.HealthCheckRegistry;
5+
import org.junit.Test;
56

67
import java.util.Map;
78

8-
import org.junit.Test;
9-
10-
import com.codahale.metrics.health.HealthCheck;
11-
import com.codahale.metrics.health.HealthCheckRegistry;
9+
import static org.hamcrest.CoreMatchers.equalTo;
10+
import static org.junit.Assert.assertFalse;
11+
import static org.junit.Assert.assertThat;
12+
import static org.junit.Assert.assertTrue;
1213

1314
public class HealthCheckTest {
15+
1416
@Test
1517
public void whenUseHealthCheck_thenHealthChecked() {
1618
HealthCheckRegistry healthCheckRegistry = new HealthCheckRegistry();
@@ -21,9 +23,8 @@ public void whenUseHealthCheck_thenHealthChecked() {
2123
assertThat(healthCheckRegistry.getNames().size(), equalTo(2));
2224

2325
Map<String, HealthCheck.Result> results = healthCheckRegistry.runHealthChecks();
24-
for (Map.Entry<String, HealthCheck.Result> entry : results.entrySet()) {
25-
assertThat(entry.getValue().isHealthy(), equalTo(true));
26-
}
26+
assertFalse(results.isEmpty());
27+
results.forEach((k, v) -> assertTrue(v.isHealthy()));
2728

2829
healthCheckRegistry.unregister("uc");
2930
assertThat(healthCheckRegistry.getNames().size(), equalTo(1));

0 commit comments

Comments
 (0)