Double Quote All Things #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a question about this! I've seen people doing PR's for both "fixing double quotes to single" and vice versa... in here and ember.js. Why is double or single better and when? |
Member
Author
|
@JulianLeviston Probably html -> Double.. JS -> Single |
|
Cool :) Just wondering why, though, or if it's just an agreed upon style. In Ruby, for instance, you use singles because doubles possibly invoke string interpolation from what I understand. |
Contributor
|
in JavaScript single and double quotes are completely the same as far as functionality goes. But as @abuiles says, there are conventions. Thus you can create HMTL tags without escapting through JS. Also it's common to use double quotes in CSS. But for all three of them it's just a convention. Each supports both, even HTML it seems: http://www.w3schools.com/html/html_attributes.asp |
|
@MajorBreakfast Thank you very much :) It's just as it seemed :) |
homu
added a commit
that referenced
this pull request
Apr 19, 2016
Update fs-extra to version 0.28.0 🚀 Hello 👋 🚀🚀🚀 [fs-extra](https://www.npmjs.com/package/fs-extra) just published its new version 0.28.0, which **is not covered by your current version range**. If this pull request passes your tests you can publish your software with the latest version of fs-extra – otherwise use this branch to work on adaptions and fixes. Happy fixing and merging 🌴 --- The new version differs by 13 commits . - [`ef35b70`](jprichardson/node-fs-extra@ef35b70) `0.28.0` - [`8c56e5b`](jprichardson/node-fs-extra@8c56e5b) `(Closes #209, Closes #237) lib/mkdirs: if invalid path char, return callback OR throw err` - [`a0cb04b`](jprichardson/node-fs-extra@a0cb04b) `(Closes #93) libs/mkdirs: prevent stack overflow if drive is not mounted in Windows` - [`76dcfa9`](jprichardson/node-fs-extra@76dcfa9) `lib/mkdirs/tests/root: skip if network drive` - [`f5c64d5`](jprichardson/node-fs-extra@f5c64d5) `gitignore: add npm debug` - [`5747fb3`](jprichardson/node-fs-extra@5747fb3) `(Closes #192) removed createOutputStream()` - [`2a5e355`](jprichardson/node-fs-extra@2a5e355) `readme: update note about hacking on fs-extra` - [`5652b96`](jprichardson/node-fs-extra@5652b96) `changelog: update issue links (auto generated)` - [`e2a7dae`](jprichardson/node-fs-extra@e2a7dae) `appveyor: node v5` - [`e8d2949`](jprichardson/node-fs-extra@e8d2949) `package: update travis` - [`a524434`](jprichardson/node-fs-extra@a524434) `readme: fix date of note` - [`e21cc16`](jprichardson/node-fs-extra@e21cc16) `readme: note about dropping old Node.js` - [`ad98995`](jprichardson/node-fs-extra@ad98995) `readme: update` See the [full diff](jprichardson/node-fs-extra@6fb9fc7...ef35b70). --- This pull request was created by [greenkeeper.io](http://greenkeeper.io/). It keeps your software up to date, all the time. <sub> Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡ </sub>
homu
added a commit
that referenced
this pull request
Apr 19, 2016
Update fs-extra to version 0.28.0 🚀 Hello 👋 🚀🚀🚀 [fs-extra](https://www.npmjs.com/package/fs-extra) just published its new version 0.28.0, which **is not covered by your current version range**. If this pull request passes your tests you can publish your software with the latest version of fs-extra – otherwise use this branch to work on adaptions and fixes. Happy fixing and merging 🌴 --- The new version differs by 13 commits . - [`ef35b70`](jprichardson/node-fs-extra@ef35b70) `0.28.0` - [`8c56e5b`](jprichardson/node-fs-extra@8c56e5b) `(Closes #209, Closes #237) lib/mkdirs: if invalid path char, return callback OR throw err` - [`a0cb04b`](jprichardson/node-fs-extra@a0cb04b) `(Closes #93) libs/mkdirs: prevent stack overflow if drive is not mounted in Windows` - [`76dcfa9`](jprichardson/node-fs-extra@76dcfa9) `lib/mkdirs/tests/root: skip if network drive` - [`f5c64d5`](jprichardson/node-fs-extra@f5c64d5) `gitignore: add npm debug` - [`5747fb3`](jprichardson/node-fs-extra@5747fb3) `(Closes #192) removed createOutputStream()` - [`2a5e355`](jprichardson/node-fs-extra@2a5e355) `readme: update note about hacking on fs-extra` - [`5652b96`](jprichardson/node-fs-extra@5652b96) `changelog: update issue links (auto generated)` - [`e2a7dae`](jprichardson/node-fs-extra@e2a7dae) `appveyor: node v5` - [`e8d2949`](jprichardson/node-fs-extra@e8d2949) `package: update travis` - [`a524434`](jprichardson/node-fs-extra@a524434) `readme: fix date of note` - [`e21cc16`](jprichardson/node-fs-extra@e21cc16) `readme: note about dropping old Node.js` - [`ad98995`](jprichardson/node-fs-extra@ad98995) `readme: update` See the [full diff](jprichardson/node-fs-extra@6fb9fc7...ef35b70). --- This pull request was created by [greenkeeper.io](http://greenkeeper.io/). It keeps your software up to date, all the time. <sub> Tired of seeing this sponsor message? Upgrade to the supporter plan! You'll also get your pull requests faster ⚡ </sub>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.