-
Notifications
You must be signed in to change notification settings - Fork 1.2k
update release-plan for OIDC #10945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update release-plan for OIDC #10945
Conversation
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so close :P
| cache: pnpm | ||
| - run: npm install -g npm@latest # ensure that the globally installed npm is new enough to support OIDC | ||
| - run: pnpm install --frozen-lockfile | ||
| - name: Publish to NPM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could conditionalize the arguments based on branch name here to enable the different branch releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that is a much better idea 👍 that will stop me from having to manage the diff all the time! thanks a million for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed it in case you want to check, although I think the syntax can really only properly be tested in prod 🫠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should work.
In ember-source I did it as two different steps with a condition https://github.com/emberjs/ember.js/blob/main/.github/workflows/publish-to-npm.yml#L32
Our last attempt to release an alpha failed because our npm token has now expired 😭
I have already setup OIDC and this PR runs
pnpm create release-plan-setup@latestto update our release-plan CI jobs to align with the new defaults and make it possible to release againNote: we can no longer have multiple publish-branchname.yml CI jobs because of OIDC, I will temporarily go back to maintaining changes across branches on this file but I have a plan to make this easier to manage going forward