Downgrade isbinaryfile #10941
Merged
Downgrade isbinaryfile #10941
+3
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 29a1467.
| "inquirer": "^13.1.0", | ||
| "is-git-url": "^1.0.0", | ||
| "is-language-code": "^5.1.0", | ||
| "isbinaryfile": "^6.0.0", |
Contributor
There was a problem hiding this comment.
This is showing removed instead of down graded?
Member
Author
There was a problem hiding this comment.
isbinaryfile is only ever used in the blueprint-model package which is a dependency of ember-cli, it shouldn't have been left in ember-cli's package.json when it was split out into its own package. This was my mistake when I split the packages
NullVoxPopuli
approved these changes
Feb 5, 2026
This was referenced Feb 5, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10928
As the upstream maintainer has stated that they will not extend the engine range for isbinaryfile our only option is to downgrade to remove the engine warning for people 👍 gjtorikian/isBinaryFile#102 (comment)
Note: once this is merged and released I will backport the second commit on this PR to the
releasebranch 👍