FEATURE: instrument add-on discovery and instantiation. Close #9373#10924
Open
gnananveshReddy wants to merge 1 commit intoember-cli:masterfrom
Open
FEATURE: instrument add-on discovery and instantiation. Close #9373#10924gnananveshReddy wants to merge 1 commit intoember-cli:masterfrom
gnananveshReddy wants to merge 1 commit intoember-cli:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Heimdall instrumentation nodes for addon discovery and instantiation as requested in #9373.
Technical Details:
=> Added ember-cli:addon-instantiation node in lib/models/instantiate-addons.js.
=> Added ember-cli:addon-discovery node in lib/models/package-info-cache/index.js.
Followed the two-space indentation syntax and ensured all nodes are stopped, including early return paths.
Testing:
=> Ran the test suite via pnpm test.