-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Promote Beta and update all dependencies for 6.10 release #10923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Missed a script -- fix updating output repos
Update RELEASE.md with more notes
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
bump minimum node version to 20.19
…tions/checkout-6 Bump actions/checkout from 4 to 6
stop using internal package cache for smoke-test-slow
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
more updates to the release process
Prepare 6.10 Alpha
Prepare Alpha Release
Update RELEASE.md
Update `chalk` dependency to latest
More dependency updates
Even more dependency updates
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # CHANGELOG.md # package.json # packages/app-blueprint/files/package.json # pnpm-lock.yaml # tests/fixtures/addon/defaults/package.json # tests/fixtures/addon/pnpm/package.json # tests/fixtures/addon/typescript/package.json # tests/fixtures/addon/yarn/package.json # tests/fixtures/app/defaults/package.json # tests/fixtures/app/embroider-no-ember-data/package.json # tests/fixtures/app/embroider-no-welcome/package.json # tests/fixtures/app/embroider-pnpm/package.json # tests/fixtures/app/embroider-yarn/package.json # tests/fixtures/app/embroider/package.json # tests/fixtures/app/no-ember-data/package.json # tests/fixtures/app/npm/package.json # tests/fixtures/app/pnpm/package.json # tests/fixtures/app/typescript-embroider-no-ember-data/package.json # tests/fixtures/app/typescript-embroider/package.json # tests/fixtures/app/typescript-no-ember-data/package.json # tests/fixtures/app/typescript/package.json # tests/fixtures/app/yarn/package.json
Prepare 6.10-beta
Prepare Beta Release
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
754e3dd to
5b2132d
Compare
5b2132d to
3a957e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is completely unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean tests pass 🤷 do we mean from a "public API" perspective?
| while ((current = current.parent)) { | ||
| // eslint-disable-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure this changes the meaning of the eslint comment
looks like it is no longer required it it lints fine while disabling a whitespace line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right... but doesn't that also imply that it wasn't needed since it didn't add an error to eslint?
|
|
||
| const { expect } = require('chai'); | ||
| const execa = require('execa'); | ||
| const { execa, hwinfo } = require('../../../lib/models/hardware-info'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks very wrong
even if that require of execa exists at that path I don't think we would use it over the regualar package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it's in a test 🤷 and also this change came from a PR to main so we should probably fix it there if at all 👍
|
|
||
| ``` | ||
| node ./dev/update-blueprint-dependencies.js --ember-source=beta --ember-data=beta | ||
| node ./dev/update-blueprint-dependencies.js --ember-source=beta --ember-data=<whatever version was in the alpha> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a bit of prose on how to answer that question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea I can add that after, the release.md needs a bit more work anyway 👍
No description provided.