stop using internal package cache for smoke-test-slow#10878
Merged
Conversation
NullVoxPopuli
approved these changes
Dec 8, 2025
Member
|
I'm curious to see how long the tests take. I tried removing the crazy PackageCache stuff awhile back and the tests took literal hours. |
Member
Author
|
Because we're now on pnpm it's much easier to rely on the global store to do all the caching for us. Before: Mocha Tests Running Time: 3:00.981 (m:ss.mmm) |
kategengler
approved these changes
Dec 8, 2025
Member
|
I don't think the speed was ever really an issue on Mac or linux. |
Member
Author
|
The Windows ones are quite bad now but not too problematic: Before: Mocha Tests Running Time: 6:19.937 (m:ss.mmm) |
This was referenced Dec 8, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I've been trying to track down the issue with #10873 for quite some time now and I am pretty sure there is something going on with the acceptance test PackageCache implementation 🙈 there is an interaction between tests that is causing eslint to hang ever since the new app blueprint started using the esm version of ember-template-compiler 🫠
We really shouldn't be doing what the package cache is doing. It's not a great system to test that packages are working correctly so I have removed it for the test that was hanging and now we're relying on the pnpm store to do our caching for us.
This might make our tests a bit slower but it's much easier to understand what is going on and should (finally) unblock the release 🎉
Edit: I merged this branch into #10873 locally and it does indeed fix the problem 🎉 plz accept and merge 🙏