[beta bugfix] allow build --watch only in EMBROIDER_PREBUILD #10846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm 👍 but wish there were tests |
Member
Author
|
@kategengler your instinct was correct, the fix was actually in the wrong place 🙈 whenever you call |
mansona
force-pushed
the
allow-watch-embroider
branch
from
df8743d to
1ef69f8
Compare
kategengler
approved these changes
Oct 13, 2025
kategengler
reviewed
Oct 13, 2025
| ); | ||
| }); | ||
|
|
||
| it('`--watch` does not throw when EMBROIDER_PREBUILD is true', function () { |
Member
There was a problem hiding this comment.
You can make the test functions async, just fyi
Member
Author
There was a problem hiding this comment.
yea I know, I just wanted it to reflect what was there already 👍
This was referenced Oct 13, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10843 we added an error for anyone calling
ember build --watchbecause it doesn't work in an embroider world. We missed the fact that Embroider itself needs to be able to call it 🙈This PR fixes that and makes sure that there are no extra warnings shown to the end-user 👍