Further contextualize help output and error when options and commands that are no longer supported in Vite-based projects are used #10843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ber help serve`)
…Classic projects (non Vite-based).
…te-based projects
Member
Author
|
It looks like |
kategengler
commented
Oct 11, 2025
| { name: 'watch', type: Boolean, default: false, aliases: ['w'] }, | ||
| { name: 'watcher', type: String }, | ||
| { name: 'suppress-sizes', type: Boolean, default: false }, | ||
| { name: 'output-path', type: 'Path', default: 'dist/', aliases: ['o'] }, |
Member
Author
There was a problem hiding this comment.
I restored --output-path since it appears to be used even in Vite-based projects (Many tests failed)
Member
There was a problem hiding this comment.
yes it turns out it is during a vite build: https://github.com/embroider-build/embroider/blob/main/packages/vite/src/build.ts#L26-L28
Test will need to be preserved for classic if the experiment is cleaned up.
… destroy` in vite-based projects
kategengler
force-pushed
the
kg-more-help
branch
from
0b4b675 to
77ca4d5
Compare
This was referenced Oct 12, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.