Add deprecation warning for the --embroider argument
#10776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichfl
force-pushed
the
mainmatter/deprecate-embroider-flag
branch
3 times, most recently
from
a276ea1 to
35f3c79
Compare
pichfl
force-pushed
the
mainmatter/deprecate-embroider-flag
branch
from
35f3c79 to
0102c1b
Compare
- for both `new` and `init` - at the top and at the bottom of the printout to make sure people don't miss it - using the existing deprecation infrastructure
pichfl
force-pushed
the
mainmatter/deprecate-embroider-flag
branch
from
0102c1b to
aecae00
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newandinitThis doesn't deprecate or remove the
EMBROIDERexperiment. It only affects the command line option.Requires ember-learn/deprecation-app#1413 to be merged for the explainer link to work
Closes #10775
This work is supported by the Mainmatter Ember Initiative.