Skip to content

remove unnecessary project override#10735

Merged
mansona merged 1 commit intomasterfrom
simplify-project
Jun 30, 2025
Merged

remove unnecessary project override#10735
mansona merged 1 commit intomasterfrom
simplify-project

Conversation

@mansona
Copy link
Member

@mansona mansona commented Jun 27, 2025

This simplifies the interaction between the Project and the Blueprint models. Now a blueprint only uses the project that is passed in 👍

@kategengler
Copy link
Member

This looks to have been added because of the crossed out #3 here #9972

If the tests pass, either it is no longer an issue, or we no longer have that scenario described in the PR.

@mansona
Copy link
Member Author

mansona commented Jun 27, 2025

We've discussed this in Discord and apparently is to support the use of the addAddonToProject API during ember new or ember addon

The conclusion is that it's unlikely that anyone is using this and our own app and addon blueprints haven't used this for a while so we can safely remove it 👍

@mansona mansona merged commit b2fa191 into master Jun 30, 2025
207 of 209 checks passed
@mansona mansona deleted the simplify-project branch June 30, 2025 09:53
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
@mansona mansona mentioned this pull request Jul 30, 2025
@mansona mansona mentioned this pull request Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants