Enabled recommended configs from eslint-plugin-n and eslint-plugin-qunit #10707
Conversation
ijlee2
force-pushed
the
enable-recommended-eslint-rules
branch
from
2a28db3 to
5cf6f1d
Compare
ijlee2
force-pushed
the
enable-recommended-eslint-rules
branch
4 times, most recently
from
d967b03 to
8c9e522
Compare
| rules: { | ||
| 'n/no-extraneous-import': 'warn', | ||
| 'n/no-unsupported-features/node-builtins': 'warn', | ||
| }, |
There was a problem hiding this comment.
There was a problem hiding this comment.
these aren't fixes tho -- they ignore the errors .
The lints are correct.
node-builtins is telling us we are using features not available on node 18, so we need to fix that.
extraneous-import is telling us that we can't import stuff that isn't in node_modules, -- we should double check that those things are there, and if not, debug what it's really complaining about <3
ijlee2
force-pushed
the
enable-recommended-eslint-rules
branch
2 times, most recently
from
acf71fb to
e98ca38
Compare
ijlee2
force-pushed
the
enable-recommended-eslint-rules
branch
from
e98ca38 to
94886c0
Compare
| }, | ||
| }, | ||
| rules: { | ||
| 'n/no-extraneous-import': 'warn', |
There was a problem hiding this comment.
Why not error?
This should stay as error / default?
There was a problem hiding this comment.
Ah, I had provided the explanation in the 2nd commit. (Workaround for unfamiliarity with ember-cli's test setup.)
There was a problem hiding this comment.
Do you have an example of an incorrect violation?
There was a problem hiding this comment.
There was a problem hiding this comment.
why is it incorrect?
| }, | ||
| rules: { | ||
| 'n/no-extraneous-import': 'warn', | ||
| 'n/no-unsupported-features/node-builtins': 'warn', |
NullVoxPopuli
force-pushed
the
enable-recommended-eslint-rules
branch
from
04dd047 to
27b8614
Compare
|
I've already pulled your changes in to https://github.com/NullVoxPopuli/ember-eslint!! |
NullVoxPopuli
force-pushed
the
enable-recommended-eslint-rules
branch
from
6337ef7 to
28b99dc
Compare
|
I'd like to land this but the tests are failing |
…atures/node-builtins to warn, because tests in ember-cli fail otherwise
…orted-features/node-builtins to warn, because tests in ember-cli fail otherwise" This reverts commit a54516d.
…o-unsupported-features/node-builtins to warn, because tests in ember-cli fail otherwise"" This reverts commit f7df0f0.
NullVoxPopuli
force-pushed
the
enable-recommended-eslint-rules
branch
from
28b99dc to
8608702
Compare
|
lgtm but lots of failures? |
nay, the only failure here is due to a breaking node change. More on that here: #10777 (comment) |
3 participants
Background
Closes #10660.
Ember CLI's blueprints for the
eslintconfig didn't enable the recommended configurations fromeslint-plugin-nandeslint-plugin-qunit.What changed?
Just like in ijlee2/frontend-configs#42, I splatted the configuration objects from
eslint-plugin-nandeslint-plugin-qunit. By splatting the objects at the top, we can always override the values that these plugins had set: