Implement the built in app, addon, and blueprint blueprints by package lookup #10671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
monorepo
branch
3 times, most recently
from
8ba3890 to
f7b252c
Compare
kategengler
reviewed
Apr 28, 2025
kategengler
reviewed
Apr 28, 2025
| "concurrently": "^9.1.2", | ||
| "ember-auto-import": "^2.10.0", | ||
| "ember-cli": "~<%= emberCLIVersion %>", | ||
| "ember-cli": "~6.4.0-beta.1", |
Member
There was a problem hiding this comment.
So this would need to be bumped along with other packages?
Member
Author
There was a problem hiding this comment.
yes exactly, I would need to add that to the script thanks for the reminder
Member
Author
There was a problem hiding this comment.
in fact this will automatically be bumped by release-plan, I have configured it correctly now to match the main ember-cli version 👍
kategengler
reviewed
Jun 26, 2025
kategengler
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly to open up a discussion of the implementation
lib/models/blueprint.js.Personally I think it would be better for maintainability if we just extract the blueprints into their own repos (not even a monorepo with each blueprint).