change mini-window height during phpactor-status#124
change mini-window height during phpactor-status#124kermorgant wants to merge 5 commits intomasterfrom
Conversation
phpactor.el
Outdated
| (defun phpactor-status () | ||
| "Execute Phpactor RPC status command, and pop to buffer." | ||
| (interactive) | ||
| (setq max-mini-window-height 18) |
There was a problem hiding this comment.
Can it be enclosed by let?
(let ((max-mini-window-height 18))
(apply #'phpactor-action-dispatch (phpactor--rpc "status" [])))let temporarily overwrites variables and restores them.
There was a problem hiding this comment.
Can you make the literal value 18 a custom variable instead of a magic number?
There was a problem hiding this comment.
@zonuexe done (with a note in the README about it)
|
Unfortunately, I had tried but I also tried temporarily taking a backup of original value and restoring it in a statement at the end but that last part (restoration) did not work. |
|
Hi @zonuexe Admitedly, this change alters a variable outside phpactor's own scope, which is not ideal. However, for user trying this package for the first time, having all the information from wdyt ? |
2 participants
I'm not really happy to change such a global variable but I did not find a working solution to have it changed only temporarily.
fixes #123